Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ./x.py tidy testing documentation #607

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Update ./x.py tidy testing documentation #607

merged 2 commits into from
Mar 10, 2020

Conversation

chrissimpkins
Copy link
Member

We are updating the rust repository ./x.py test docs to use the tidy argument in rust-lang/rust#69603:

./x.py test tidy

This replaces the previous recommendation to use the source directory path:

./x.py test src/tools/tidy

This PR updates the rustc-dev-guide docs to use the same recommendation.

@JohnTitor
Copy link
Member

I remember test src/tools/tidy is used more widely, could you also update them?

@chrissimpkins chrissimpkins mentioned this pull request Mar 10, 2020
Merged
@chrissimpkins
Copy link
Member Author

I remember test src/tools/tidy is used more widely, could you also update them?

Sorry, I'm not sure that I am following you. You suggest that we use ./x.py test src/tools/tidy as it was before the changes here?

@JohnTitor
Copy link
Member

I mean let's update all the use of src/tools/tidy in this PR.

@chrissimpkins
Copy link
Member Author

Missed the others. Thanks! Updated in cfee86e

JohnTitor
JohnTitor approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohnTitor JohnTitor merged commit 56cff94 into rust-lang:master Mar 10, 2020
@chrissimpkins chrissimpkins deleted the tidy-docs-update branch March 10, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrissimpkins @JohnTitor